#31320: Prevent BEGIN and COMMIT in RunSQL in atomic migrations.
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: nobody
Johnson |
Type: New feature | Status: closed
Component: Migrations | Version: master
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):
* cc: Simon Charette (added)
Comment:
> And we already parse the SQL in RunSQL for splitting, so it doesn't seem
like it would be much overhead to me to make a pass over the tokens at
that point and warn/error.
Yes, but not on PostgreSQL. For a long statements this can introduce a
performance regression, IMO. Do you want to prepare a patch? I'm not
convinced that we need to be more protective in `RunSQL()`, I've used it
many times but always for a complicated data migrations.
--
Ticket URL: <https://code.djangoproject.com/ticket/31320#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.23c22d5298323f7ca61f95f421748045%40djangoproject.com.
