#35154: QuerySet implements `contains` but not `__contains__`
-------------------------------------+-------------------------------------
Reporter: fidoriel | Owner: nobody
Type: New feature | Status: closed
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Normal | Resolution: wontfix
Keywords: queryset contains | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Tim Graham:
Old description:
> This is a similar proposal to
> https://code.djangoproject.com/ticket/31561, but it is not the same.
> Currently using
> {{{
> x in myQuerySet
> }}}
> results in python using the fallback solution:
> https://docs.python.org/3/reference/expressions.html#membership-test-
> details
> Because https://groups.google.com/g/django-
> developers/c/NZaMq9BALrs/m/OCNTh6QyCAAJ deiced to implement contains in
> https://code.djangoproject.com/ticket/24141
> I think it is only consistent to have the same behavior implemented in
> `__contains__`. I would expect that, it is also a more efficient
> implementation and unifies django behavior. Nevertheless, documentation
> is needed why this inconsistency exists. I was not able to find a reason.
> Because the mailing list agreed on adding contains, this is discussed
> behavior. Why was `__contains__` not added in the first place? To not
> have breaking changes? I cannot see what would break.
>
> As said in https://code.djangoproject.com/ticket/31561 a queryset could
> be a collection to make typing easier. But this is not the intention of
> this issue.
New description:
This is a similar proposal to #31561, but it is not the same. Currently
using `x in myQuerySet` results in Python using the fallback solution:
https://docs.python.org/3/reference/expressions.html#membership-test-
details because https://groups.google.com/g/django-
developers/c/NZaMq9BALrs/m/OCNTh6QyCAAJ decided to implement contains in
#24141.
I think it is only consistent to have the same behavior implemented in
`__contains__`. I would expect that, it is also a more efficient
implementation and unifies Django behavior. Nevertheless, documentation is
needed why this inconsistency exists. I was not able to find a reason.
Because the mailing list agreed on adding contains, this is discussed
behavior. Why was `__contains__` not added in the first place? To not have
breaking changes? I cannot see what would break.
As said in #31561 a queryset could be a collection to make typing easier.
But this is not the intention of this issue.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/35154#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018d5a4f7fa6-4c473ddd-f5da-409b-869d-cc82d1905612-000000%40eu-central-1.amazonses.com.
