#35154: QuerySet implements `contains` but not `__contains__`
-------------------------------------+-------------------------------------
Reporter: fidoriel | Owner: nobody
Type: | Status: new
Uncategorized |
Component: Database | Version: 5.0
layer (models, ORM) |
Severity: Normal | Keywords: queryset contains
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
This is a similar proposal to https://code.djangoproject.com/ticket/31561,
but it is not the same. Currently using
{{{
x in myQuerySet
}}}
results in python using the fallback solution:
https://docs.python.org/3/reference/expressions.html#membership-test-
details
Because https://groups.google.com/g/django-
developers/c/NZaMq9BALrs/m/OCNTh6QyCAAJ deiced to implement contains in
https://code.djangoproject.com/ticket/24141
I think it is only consistent to have the same behavior implemented in
__contains__. I would expect that, it is also a more efficient
implementation and unifies django behavior. Nevertheless, documentation is
needed why this inconsistency exists. I was not able to find a reason.
Because the mailing list agreed on adding contains, this is discussed
behavior. Why was __contains__ not added in the first place? To not have
breaking changes? I cannot see what would break.
As said in https://code.djangoproject.com/ticket/31561 a queryset could be
a collection to make typing easier. But this is not the intention of this
issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/35154>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018d593971d1-32ad5143-462f-434a-9e92-19f041f12e46-000000%40eu-central-1.amazonses.com.
