On Wed, 8 Aug 2007, Jukka Salmi wrote:
> dkim-stats(8) always prints "[...] last l=1, a=0, [...]", even if the 
> last verified message didn't have an `l' tag or if the algorithm was 
> rsa-sha256. Checking `canonlen' and `msglen' just before the call to 
> dkimf_stats_record() in dkim-filter.c, it seems that the former is set 
> correctly but the latter is always zero. That's why `tmp_lengths = 
> (msglen != canonlen)' is always 1. Same for `tmp_signalg': it's always 
> zero.

I found and fixed the "msglen" problem.  When I reworked the 
canonicalization code recently, the update to dkim_bodylen was removed. 
That's been restored.

There was also an inexplicable line which reset the signing algorithm 
that's now been removed.

One problem remains though, which is the "msglen != canonlen" test. 
"msglen" contains the total number of body bytes seen; however, "canonlen" 
could be short even if "l=" is not in use because trailing CRLFs are not 
canonicalized.  I'll have to look into a different test for that case.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
dkim-milter-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dkim-milter-discuss

Reply via email to