Thanks, It appears it is done. when I go to pull request of DoctrineExtensions I can see mine as an open pull request... I think now Benjamin should approve it that it moves to his repository...
On Mon, Feb 24, 2014 at 5:29 PM, Herman Peeren <[email protected]>wrote: > But: then it is my contribution, not yours. Better do it yourself. Learn > once, use often. As you are an advanced developer (why would you otherwise > use tools like Doctrine ORM or even ionCube...) you use a version control > system; otherwise it's the first thing learning now. When doing anything > with open source, Git is worth considering as VCS. > > How to make a Pull Request on Github is beyond this mailinglist, but > everything can be found about that online (or books about git). The basic > scheme is: https://help.github.com/articles/creating-a-pull-request . > That is: take a github account (free), fork the repo you want to add to, > fetch it in an offline repo, add your code (mostly done in a new branch), > push that to your online repo and issue a pull request. > > On Monday, 24 February 2014 14:36:04 UTC+1, Herman Peeren wrote: >> >> On Monday, 24 February 2014 14:10:57 UTC+1, Parsifal wrote: >>> >>> Yestederday, Marco told me that I should pull request on github and add >>> from_unixtime extension I made. But pull request was disabled. I guess I >>> was on a wrong section of github (DoctrineExtensions repository). Was I >>> right there or I should hit pull request of core doctrine repository? Sorry >>> but I am unfamiliar with github. >>> >> >> Probably not. those database-specific extensions are in >> https://github.com/beberlei/DoctrineExtensions and not in the main >> ORM-repo. So I think your from_unixtime belongs in >> https://github.com/beberlei/DoctrineExtensions/tree/ >> master/lib/DoctrineExtensions/Query/Mysql >> >> You wrote "I see the ability to pull request is disabled!". I don't see >> that. Maybe you are doing something wrong there. I assume you have a Github >> repository, otherwise you cannot make a Pull Request. If making a PR >> against Beberlei's repo is disabled, then you can always just leave it in >> your own Github-repository: then it is publicly available too. >> >> -- > You received this message because you are subscribed to the Google Groups > "doctrine-user" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/doctrine-user. > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "doctrine-user" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/doctrine-user. For more options, visit https://groups.google.com/groups/opt_out.
