Thanks for encourge me. Though I am not sure if Benjamin considers to accept new pulls request any more, as he said there, this repository is no longer maintained. در 2014 2 24 18:44، "Herman Peeren" <[email protected]> نوشت:
> On Monday, 24 February 2014 18:01:00 UTC+1, Parsifal wrote: > >> Thanks, It appears it is done. when I go to pull request of >> DoctrineExtensions I can see mine as an open pull request... >> I think now Benjamin should approve it that it moves to his repository... >> >> OK, nice, thanks. Be prepared though that sometimes when contributing to > an open source project you'll get some short notice back about missing > documentation, not conform style standards, missing tests, wrong > implementation or whatever. It is never meant personally, but a sign of > good quality control. > > -- > You received this message because you are subscribed to the Google Groups > "doctrine-user" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/doctrine-user. > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "doctrine-user" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/doctrine-user. For more options, visit https://groups.google.com/groups/opt_out.
