On Friday 16 November 2012, 13:49, Zieris, Franz wrote: > Hi Kevin, > > > We've just noticed that current master seems to be quite broken wrt the > > Chat Control/View functionality. > Nope, the master is not broken -- and I can tell this without looking at the > code. Gerrit allows no submission of patches to the master (or any other > branch) without fulfilling the following criteria: * The must be no > compilation errors. > * The test suite must run without any errors. > * The patch must be reviewed, i.e. have a "+2" rating. > > As I pointed out two times in the recent past, working on something > chat-related is somewhat tricky at the moment (see mails on dpp-devel [1] > and [2]). Feel free to ask further questions, after you read and understood > those mails. > > Best Regards, > Franz > > [1] http://thread.gmane.org/gmane.comp.ide.eclipse.saros.devel/354 > (2012-11-09, seven days ago) [2] > http://thread.gmane.org/gmane.comp.ide.eclipse.saros.devel/368 (2012-11-12, > four days ago) > > -----Original Message----- > From: Kevin Funk [mailto:kevin.f...@fu-berlin.de] > Sent: Friday, November 16, 2012 1:42 PM > To: Zieris, Franz > Cc: dpp-devel@lists.sourceforge.net; erik.ku...@gmail.com > Subject: Re: [DPP-Devel] Fixing bug 3572488 / Gerrit access > > On Friday 16 November 2012, 13:37, Zieris, Franz wrote: > > Hi Kevin, > > > > > I'd like to ask for access to the Gerrit Git repository so we can > > > upload our changes and get some feedback on it. > > > > Done. You should now be able to push new commits to Gerrit and receive > > feedback (and also rate other changes with either "-1", "0" or "+1"). > > > > If something goes wrong, please read the error message EGit prompts. > > In 95% of the cases, the solution is hidden in the message. If you > > need help, make sure to provide the error message in your mail to the > > mailing list. > > > > Best Regards, > > Franz > > Hey, > > We've just noticed that current master seems to be quite broken wrt the Chat > Control/View functionality. > > Apparently that's caused by the integration of [1]. Now we can't even test > the patch in the ChatControl demo we've implemented, because of a lot of > unrelated compilation errors in the code base. > > Someone has to fix this first :) > > See attached file. > > [1] http://saros-build.imp.fu-berlin.de/gerrit/#/c/284/ > > -- > Kevin Funk
I see, still, our problem seems valid. The compilation errors are from 'de.fu_berlin.inf.dpp.ui.widgetGallery', which apparently is not covered by CI, right? We added a button to the chat control demo (which updates the user color of some participant) so we can test our changes quickly. Does it make sense to fix the widgetGallery errors first? Or is that sub- project deprecated anyway? Greets -- Kevin Funk ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ DPP-Devel mailing list DPP-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dpp-devel
