Hi all, our CI does not run in PDE mode, so please do not try to write PDE JUnit tests. They may be executed by the CI and the result would be almost always a failure.
If your code resides in a package like *.ui.* = Do not write a JUnit test, use the STF. As for the STF, yes you cannot control OS dialogs. As the current logic of changing colors is messed up (there is no method like ISarosSession session; session.changeColor(RGB color) or something like that), I would not recommend to find a workaround. Also analysing colors in the chat view, well. Even if they are wrong, this would be only confusing. What would be critical: if the annotation colors in the editors does not match the user color that is displayed in the session view. BR, Stefan Am 19.11.2012 17:13, schrieb Zieris, Franz: > Hi Kevin, > > Push your changes to Gerrit and we will see. > > In general: The purpose of the Unit and STF test suites is not to have a > replay for each and every entry in the bugtracker. We want to ensure the > integrity of important portions of the code (unit tests) and the > functionality of important Use Cases (STF tests). > > Best Regards, > Franz > > -----Original Message----- > From: Kevin Funk [mailto:kevin.f...@fu-berlin.de] > Sent: Monday, November 19, 2012 10:59 AM > To: Zieris, Franz > Cc: dpp-devel@lists.sourceforge.net; erik.ku...@gmail.com > Subject: Re: [DPP-Devel] Fixing bug 3572488 / Gerrit access > > On Friday 16 November 2012, 17:49, Zieris, Franz wrote: >> Hi Kevin, >> >>> I'll postpone our changes until that works. As it provides a great >>> way to test our new feature. >> I see no reason for postponing. I can give no warranties whether I'll >> actually have time for that in the next days or even weeks. Yes, it >> would be nice for testing, but I'm pretty sure you're able to provide >> a patch for bug #3572488 without the widgetGallery. >> >> Best Regards, >> Franz > Hey, > > is there any interest in testing the color-change functionality in a chat > session? > > We just tried to implement this and noticed that there is no support in the > SWTBot framework to test native color choser dialogs. So, actually, we can't > implement a proper STF test for this (because we can't select a color). As a > work-around we tried to get a hold of the Saros session (ISarosSession) of > the ALICE user and send the ColorChangedActivity event manually - but that > won't work either, because we can't call the functions of the session object > via RMI. > > So the questions are: > * Do you actually want us to implement a unit test for testing the new > functionality? > * If yes, how are we supposed to do this? > > If both answers to the questions are "no" I am just going to push the changes > (120 lines diff) via Gerrit this evening. > > Greets > > -- > Kevin Funk > > ------------------------------------------------------------------------------ > Monitor your physical, virtual and cloud infrastructure from a single > web console. Get in-depth insight into apps, servers, databases, vmware, > SAP, cloud infrastructure, etc. Download 30-day Free Trial. > Pricing starts from $795 for 25 servers or applications! > http://p.sf.net/sfu/zoho_dev2dev_nov > _______________________________________________ > DPP-Devel mailing list > DPP-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/dpp-devel ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ DPP-Devel mailing list DPP-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dpp-devel
