On Friday 16 November 2012, 14:54, Zieris, Franz wrote: > Hi Kevin, > > > The compilation errors are from > > 'de.fu_berlin.inf.dpp.ui.widgetGallery', which apparently is not covered > > by > > CI, right? > > Yes, you're right. The widgetGallery is a tool for developers, and its code > is not relevant for the productive code of Saros. And unlike the JUnit and > STF code it is also not a necessary part for ensuring Saros's integrity. > Thus, there is no need to import de.fu_berlin.inf.dpp.ui.widgetGallery in > your Eclipse workspace. And even if you do so, despite these errors you > should be able to run and test your local Saros instances anyway. > > Does it make sense to fix the widgetGallery errors first? Or is that sub- > > project deprecated anyway? > > Its deprecation is nothing that has been seriously considered yet, but > putting it in second place is some kind of pre-stage of deprecation. As a > countermeasure I already did some maintenance in September (see [1]), but > as you pointed out, the recent chat-related patches didn't take care of the > widgetGallery, thus introducing unrecognized or underrated compilation > errors. > > Too sum things up: Of course you're free to provide a patch for fixing the > widgetGallery as well. And if you don't, I'll do it during the next days. > However, thanks for bringing the widgetGallery back to my mind! > > Best Regards, > Franz > > > [1] http://saros-build.imp.fu-berlin.de/gerrit/293
Feel free to do so. I just tried to rebase the widgetGallery stuff onto the new changes in master but failed to do so - it requires a lot of insight in the way the new IChat-based stuff works. I cannot come up with a way to create a ChatControl instance without having a session object. I'll postpone our changes until that works. As it provides a great way to test our new feature. Greets -- Kevin Funk ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ DPP-Devel mailing list DPP-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dpp-devel
