[PATCH v1 01/26] drm/drm_panel: no error when no callback

[Sam Ravnborg]

The callbacks in drm_panel_funcs are optional, so do not
return an error just because no callback is assigned.

Signed-off-by: Sam Ravnborg <s...@ravnborg.org>
Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
Cc: Maxime Ripard <mrip...@kernel.org>
Cc: Thierry Reding <thierry.red...@gmail.com>
Cc: Sam Ravnborg <s...@ravnborg.org>
Cc: David Airlie <airl...@linux.ie>
Cc: Daniel Vetter <dan...@ffwll.ch>
---
 drivers/gpu/drm/drm_panel.c | 35 +++++++++++++++++++++++++----------
 1 file changed, 25 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
index ed7985c0535a..2d59cdd05e50 100644
--- a/drivers/gpu/drm/drm_panel.c
+++ b/drivers/gpu/drm/drm_panel.c
@@ -151,10 +151,13 @@ EXPORT_SYMBOL(drm_panel_detach);
  */
 int drm_panel_prepare(struct drm_panel *panel)
 {
-       if (panel && panel->funcs && panel->funcs->prepare)
+       if (!panel)
+               return -EINVAL;
+
+       if (panel->funcs && panel->funcs->prepare)
                return panel->funcs->prepare(panel);
 
-       return panel ? -ENOSYS : -EINVAL;
+       return 0;
 }
 EXPORT_SYMBOL(drm_panel_prepare);
 
@@ -171,10 +174,13 @@ EXPORT_SYMBOL(drm_panel_prepare);
  */
 int drm_panel_unprepare(struct drm_panel *panel)
 {
-       if (panel && panel->funcs && panel->funcs->unprepare)
+       if (!panel)
+               return -EINVAL;
+
+       if (panel->funcs && panel->funcs->unprepare)
                return panel->funcs->unprepare(panel);
 
-       return panel ? -ENOSYS : -EINVAL;
+       return 0;
 }
 EXPORT_SYMBOL(drm_panel_unprepare);
 
@@ -190,10 +196,13 @@ EXPORT_SYMBOL(drm_panel_unprepare);
  */
 int drm_panel_enable(struct drm_panel *panel)
 {
-       if (panel && panel->funcs && panel->funcs->enable)
+       if (!panel)
+               return -EINVAL;
+
+       if (panel->funcs && panel->funcs->enable)
                return panel->funcs->enable(panel);
 
-       return panel ? -ENOSYS : -EINVAL;
+       return 0;
 }
 EXPORT_SYMBOL(drm_panel_enable);
 
@@ -209,10 +218,13 @@ EXPORT_SYMBOL(drm_panel_enable);
  */
 int drm_panel_disable(struct drm_panel *panel)
 {
-       if (panel && panel->funcs && panel->funcs->disable)
+       if (!panel)
+               return -EINVAL;
+
+       if (panel->funcs && panel->funcs->disable)
                return panel->funcs->disable(panel);
 
-       return panel ? -ENOSYS : -EINVAL;
+       return 0;
 }
 EXPORT_SYMBOL(drm_panel_disable);
 
@@ -228,10 +240,13 @@ EXPORT_SYMBOL(drm_panel_disable);
  */
 int drm_panel_get_modes(struct drm_panel *panel)
 {
-       if (panel && panel->funcs && panel->funcs->get_modes)
+       if (!panel)
+               return -EINVAL;
+
+       if (panel->funcs && panel->funcs->get_modes)
                return panel->funcs->get_modes(panel);
 
-       return panel ? -ENOSYS : -EINVAL;
+       return 0;
 }
 EXPORT_SYMBOL(drm_panel_get_modes);
 
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel