[PATCH v1 10/26] drm/panel: ilitek-ili9881c: use drm_panel backlight support

[Sam Ravnborg]

Use the backlight support in drm_panel to simplify the driver

Signed-off-by: Sam Ravnborg <s...@ravnborg.org>
Cc: Thierry Reding <thierry.red...@gmail.com>
Cc: Sam Ravnborg <s...@ravnborg.org>
---
 drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c 
b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index 31e5a4e67750..f54077c216a3 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -3,7 +3,6 @@
  * Copyright (C) 2017-2018, Bootlin
  */
 
-#include <linux/backlight.h>
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/err.h>
@@ -25,7 +24,6 @@ struct ili9881c {
        struct drm_panel        panel;
        struct mipi_dsi_device  *dsi;
 
-       struct backlight_device *backlight;
        struct regulator        *power;
        struct gpio_desc        *reset;
 };
@@ -348,7 +346,6 @@ static int ili9881c_enable(struct drm_panel *panel)
        msleep(120);
 
        mipi_dsi_dcs_set_display_on(ctx->dsi);
-       backlight_enable(ctx->backlight);
 
        return 0;
 }
@@ -357,7 +354,6 @@ static int ili9881c_disable(struct drm_panel *panel)
 {
        struct ili9881c *ctx = panel_to_ili9881c(panel);
 
-       backlight_disable(ctx->backlight);
        return mipi_dsi_dcs_set_display_off(ctx->dsi);
 }
 
@@ -423,7 +419,6 @@ static const struct drm_panel_funcs ili9881c_funcs = {
 
 static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
 {
-       struct device_node *np;
        struct ili9881c *ctx;
        int ret;
 
@@ -448,14 +443,9 @@ static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
                return PTR_ERR(ctx->reset);
        }
 
-       np = of_parse_phandle(dsi->dev.of_node, "backlight", 0);
-       if (np) {
-               ctx->backlight = of_find_backlight_by_node(np);
-               of_node_put(np);
-
-               if (!ctx->backlight)
-                       return -EPROBE_DEFER;
-       }
+       ret = drm_panel_of_backlight(&ctx->panel);
+       if (ret)
+               return ret;
 
        ret = drm_panel_add(&ctx->panel);
        if (ret < 0)
@@ -475,9 +465,6 @@ static int ili9881c_dsi_remove(struct mipi_dsi_device *dsi)
        mipi_dsi_detach(dsi);
        drm_panel_remove(&ctx->panel);
 
-       if (ctx->backlight)
-               put_device(&ctx->backlight->dev);
-
        return 0;
 }
 
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel