On 5/8/25 10:12 PM, Connor Abbott wrote:
> On Thu, May 8, 2025 at 2:13 PM Konrad Dybcio <konradyb...@kernel.org> wrote:
>>
>> From: Konrad Dybcio <konrad.dyb...@oss.qualcomm.com>
>>
>> Add a file that will serve as a single source of truth for UBWC
>> configuration data for various multimedia blocks.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dyb...@oss.qualcomm.com>
>> ---
[...]
>> +struct qcom_ubwc_cfg_data {
>> + u32 ubwc_enc_version;
>> + /* Can be read from MDSS_BASE + 0x58 */
>> + u32 ubwc_dec_version;
>> + u32 ubwc_swizzle;
>> + int highest_bank_bit;
>> + bool ubwc_bank_spread;
>> + bool macrotile_mode;
>> + u32 mdss_reg_bus_bw;
>
> This doesn't really seem relevant to UBWC?
I'll admit I just took it with the rest of properties for a simpler transition.
Generally, we could ma-a-a-aybe just make up a common value and pray it doesn't
break anything, as we're taking numbers that translate to ANYTHING_ABOVE_OFF or
ANYTHING_ABOVE_OFF_PLUS_1 in most cases wrt a cpu-ipblock path.
>
>> +};
>
> The comments should be copied over from the Adreno struct. That was
> the main way the meaning of most of these was documented and you're
> deleting it here.
I'll do that.
Konrad
