On Wed, May 14, 2025 at 05:10:21PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dyb...@oss.qualcomm.com>
> 
> Add a file that will serve as a single source of truth for UBWC
> configuration data for various multimedia blocks.
> 
> Signed-off-by: Konrad Dybcio <konrad.dyb...@oss.qualcomm.com>
> ---
>  drivers/soc/qcom/Kconfig       |   8 ++
>  drivers/soc/qcom/Makefile      |   1 +
>  drivers/soc/qcom/ubwc_config.c | 235 
> +++++++++++++++++++++++++++++++++++++++++
>  include/linux/soc/qcom/ubwc.h  |  67 ++++++++++++
>  4 files changed, 311 insertions(+)
> 

With the SAR2130P fixed

Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@oss.qualcomm.com>


> +
> +     /**
> +      * @highest_bank_bit: Highest Bank Bit
> +      *
> +      * The Highest Bank Bit value represents the bit of the highest
> +      * DDR bank.  This should ideally use DRAM type detection.
> +      */
> +     int highest_bank_bit;
> +     bool ubwc_bank_spread;

Nit: any documentation for this one?

> +
> +     /**
> +      * @macrotile_mode: Macrotile Mode
> +      *
> +      * Whether to use 4-channel macrotiling mode or the newer
> +      * 8-channel macrotiling mode introduced in UBWC 3.1. 0 is
> +      * 4-channel and 1 is 8-channel.
> +      */
> +     bool macrotile_mode;
> +};
> +

-- 
With best wishes
Dmitry

Reply via email to