On 5/14/25 9:03 PM, Dmitry Baryshkov wrote: > On Wed, May 14, 2025 at 05:10:21PM +0200, Konrad Dybcio wrote: >> From: Konrad Dybcio <konrad.dyb...@oss.qualcomm.com> >> >> Add a file that will serve as a single source of truth for UBWC >> configuration data for various multimedia blocks. >> >> Signed-off-by: Konrad Dybcio <konrad.dyb...@oss.qualcomm.com> >> --- >> drivers/soc/qcom/Kconfig | 8 ++ >> drivers/soc/qcom/Makefile | 1 + >> drivers/soc/qcom/ubwc_config.c | 235 >> +++++++++++++++++++++++++++++++++++++++++ >> include/linux/soc/qcom/ubwc.h | 67 ++++++++++++ >> 4 files changed, 311 insertions(+) >> > > With the SAR2130P fixed > > Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@oss.qualcomm.com> > > >> + >> + /** >> + * @highest_bank_bit: Highest Bank Bit >> + * >> + * The Highest Bank Bit value represents the bit of the highest >> + * DDR bank. This should ideally use DRAM type detection. >> + */ >> + int highest_bank_bit; >> + bool ubwc_bank_spread; > > Nit: any documentation for this one?
Not even documentation seems to acknowledge that bit's existence Konrad