On Wed, 02 Jul 2025, Uma Shankar <uma.shan...@intel.com> wrote:
> From: Chaitanya Kumar Borah <chaitanya.kumar.bo...@intel.com>
>
> Add macros to identify intel color blocks. It will help
> in mapping drm_color_ops to intel color HW blocks
>
> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.bo...@intel.com>
> Signed-off-by: Uma Shankar <uma.shan...@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_limits.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_limits.h
> b/drivers/gpu/drm/i915/display/intel_display_limits.h
> index f0fa27e365ab..97c960cc16aa 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_limits.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_limits.h
> @@ -138,4 +138,17 @@ enum hpd_pin {
> HPD_NUM_PINS
> };
>
> +/*
> + * Intel Color Blocks
> + *
> + */
> +
How does the comment help anything? The name of the struct is
intel_color_block.
> +enum intel_color_block {
> + CB_PLANE_PRE_CSC_LUT,
> + CB_PLANE_CSC,
> + CB_PLANE_POST_CSC_LUT,
> +
> + I915_MAX_CB
Why I915? This has less and less to do with i915 nowadays. Maybe all of
these should be INTEL_ prefixed?
> +};
> +
> #endif /* __INTEL_DISPLAY_LIMITS_H__ */
--
Jani Nikula, Intel
