On Thu, Oct 23, 2025 at 03:01:14PM +0300, Dmitry Baryshkov wrote: > On Thu, Oct 23, 2025 at 03:53:53PM +0800, yuanjie yang wrote: > > From: Yuanjie Yang <[email protected]> > > > > Add mdss support for the Qualcomm Kaanapali platform. > > > > Signed-off-by: Yongxing Mou <[email protected]> > > Signed-off-by: Yuanjie Yang <[email protected]> > > --- > > drivers/gpu/drm/msm/msm_mdss.c | 22 ++++++++++++++++++++++ > > include/linux/soc/qcom/ubwc.h | 1 + > > 2 files changed, 23 insertions(+) > > Where can I find the UBWC config for Kaanapali?
https://lore.kernel.org/all/[email protected]/ I see UBWC config is in gpu patch list, so I don't push UBWC config patch in my patch list. so I should wait gpu patch applied and rebase this patch ? Thanks, Yuanjie > > > > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > > index 2d0e3e784c04..665751d2b999 100644 > > --- a/drivers/gpu/drm/msm/msm_mdss.c > > +++ b/drivers/gpu/drm/msm/msm_mdss.c > > @@ -243,6 +243,24 @@ static void msm_mdss_setup_ubwc_dec_50(struct msm_mdss > > *msm_mdss) > > writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); > > } > > > > +static void msm_mdss_setup_ubwc_dec_60(struct msm_mdss *msm_mdss) > > +{ > > + const struct qcom_ubwc_cfg_data *data = msm_mdss->mdss_data; > > + u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | > > + MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit); > > + > > + if (data->ubwc_bank_spread) > > + value |= MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; > > + > > + if (data->macrotile_mode) > > + value |= MDSS_UBWC_STATIC_MACROTILE_MODE; > > + > > + writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); > > + > > + writel_relaxed(5, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); > > + writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); > > +} > > + > > static int msm_mdss_enable(struct msm_mdss *msm_mdss) > > { > > int ret, i; > > @@ -296,6 +314,9 @@ static int msm_mdss_enable(struct msm_mdss *msm_mdss) > > case UBWC_5_0: > > msm_mdss_setup_ubwc_dec_50(msm_mdss); > > break; > > + case UBWC_6_0: > > + msm_mdss_setup_ubwc_dec_60(msm_mdss); > > + break; > > default: > > dev_err(msm_mdss->dev, "Unsupported UBWC decoder version %x\n", > > msm_mdss->mdss_data->ubwc_dec_version); > > @@ -552,6 +573,7 @@ static const struct msm_mdss_data data_153k6 = { > > }; > > > > static const struct of_device_id mdss_dt_match[] = { > > + { .compatible = "qcom,kaanapali-mdss", .data = &data_57k }, > > { .compatible = "qcom,mdss", .data = &data_153k6 }, > > { .compatible = "qcom,msm8998-mdss", .data = &data_76k8 }, > > { .compatible = "qcom,qcm2290-mdss", .data = &data_76k8 }, > > diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h > > index 1ed8b1b16bc9..0a4edfe3d96d 100644 > > --- a/include/linux/soc/qcom/ubwc.h > > +++ b/include/linux/soc/qcom/ubwc.h > > @@ -52,6 +52,7 @@ struct qcom_ubwc_cfg_data { > > #define UBWC_4_0 0x40000000 > > #define UBWC_4_3 0x40030000 > > #define UBWC_5_0 0x50000000 > > +#define UBWC_6_0 0x60000000 > > This should be tied with the ubwc config changes as this chunk goes into > a different subsystem. > > > > > #if IS_ENABLED(CONFIG_QCOM_UBWC_CONFIG) > > const struct qcom_ubwc_cfg_data *qcom_ubwc_config_get_data(void); > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry
