Hi Marek,

On 03/11/2025 20:07, Marek Vasut wrote:
> Document Imagination Technologies PowerVR Rogue GE7800 BNVC 15.5.1.64
> present in Renesas R-Car R8A77965 M3-N SoC.
> 
> Signed-off-by: Marek Vasut <[email protected]>
> ---
> Cc: Conor Dooley <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Frank Binns <[email protected]>
> Cc: Geert Uytterhoeven <[email protected]>
> Cc: Krzysztof Kozlowski <[email protected]>
> Cc: Maarten Lankhorst <[email protected]>
> Cc: Magnus Damm <[email protected]>
> Cc: Matt Coster <[email protected]>
> Cc: Maxime Ripard <[email protected]>
> Cc: "Niklas Söderlund" <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Simona Vetter <[email protected]>
> Cc: Thomas Zimmermann <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
>  .../devicetree/bindings/gpu/img,powervr-rogue.yaml          | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml 
> b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> index a7ca6d3fdf10..c03efbedc397 100644
> --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> @@ -19,6 +19,10 @@ properties:
>                - renesas,r8a77961-gpu
>            - const: img,img-gx6250
>            - const: img,img-rogue
> +      - items:
> +          - const: renesas,r8a77965-gpu
> +          - const: img,img-ge7800
> +          - const: img,img-rogue
>        - items:
>            - enum:
>                - ti,am62-gpu
> @@ -105,6 +109,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - img,img-ge7800
>                - img,img-gx6250

Can you put these in the same order they're declared above? The way I
read it, the order is img,xxx in generational order followed by
soc-specific entries in alphabetical order (which is why we have
img,img-gx6250 before img,img-bxs-4-64 below).

>                - thead,th1520-gpu
>      then:
> @@ -134,6 +139,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - img,img-ge7800
>                - img,img-gx6250

Same again, otherwise lgtm.

Cheers,
Matt

>                - img,img-bxs-4-64
>      then:

-- 
Matt Coster
E: [email protected]

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to