Re: [PATCH 1/2] dt-bindings: gpu: img, powervr-rogue: Document GE7800 GPU in Renesas R-Car M3-N

[Marek Vasut]

On 11/4/25 12:52 PM, Matt Coster wrote:

Hello Matt,

+++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
@@ -19,6 +19,10 @@ properties:
                - renesas,r8a77961-gpu
            - const: img,img-gx6250
            - const: img,img-rogue
+      - items:
+          - const: renesas,r8a77965-gpu
+          - const: img,img-ge7800
+          - const: img,img-rogue
        - items:
            - enum:
                - ti,am62-gpu
@@ -105,6 +109,7 @@ allOf:
          compatible:
            contains:
              enum:
+              - img,img-ge7800
                - img,img-gx6250

Can you put these in the same order they're declared above? The way I
read it, the order is img,xxx in generational order followed by
soc-specific entries in alphabetical order (which is why we have
img,img-gx6250 before img,img-bxs-4-64 below).

In this enum, the entries are (should be) sorted alphabetically .

Do you want to sort them generationally instead ?

                - thead,th1520-gpu
      then:
@@ -134,6 +139,7 @@ allOf:
          compatible:
            contains:
              enum:
+              - img,img-ge7800
                - img,img-gx6250

Same again, otherwise lgtm.

Please see above.