On Wed Feb 4, 2026 at 4:46 PM GMT, Danilo Krummrich wrote:
> On Wed Feb 4, 2026 at 5:06 PM CET, Andreas Hindborg wrote:
>> It is my understanding that the SoB needs confirmation from the author
>> if the code was changed. I changed the code and did not want to bother
>> the original author, because it is my understanding they do not wish to
>> be contacted. I did not want to misrepresent the original author, and so
>> I did not change the "From:" line.
>
> Frankly, I don't know what's the correct thing to do in this case; maybe the
> correct thing is to just keep the SoB, but list all the changes that have been
> made.
>
> Technically, the same thing is common practice when maintainers (including
> myself) apply (minor) changes to a patch when applying them to their tree.
>
>> How would you prefer to account for the work by Abdiel and Boqun?
>
> I mean, I don't have a preference and if I would have one, it wouldn't be
> relevant. :) I just wanted to bring it up since the very first version was 
> sent
> by the two of them. So, I think we should just ask.

It looks to me that they're independent works, there're very clear difference
between the two patches. Lina's patch closely follows the ARef design, and it
looks it also takes into account the dropck (by having `PhantomData`) and have
send/sync considerations.

Best,
Gary

Reply via email to