On Thu, Feb 12, 2026 at 12:05:38PM +0100, Boris Brezillon wrote: > On Wed, 11 Feb 2026 17:37:09 -0800 > Deborah Brouwer <[email protected]> wrote: > > > + > > +impl Mmu { > > + pub(crate) fn new( > > + pdev: &platform::Device, > > + iomem: ArcBorrow<'_, Devres<IoMem>>, > > + gpu_info: &GpuInfo, > > + ) -> Result<Arc<Mmu>> { > > Maybe the Mmu should be wrapped in a Devres, like we do with other HW > components that require the underlying device to be bound to access > registers. I mean, we do have iomem wrapper into a Devres, so maybe > that's not needed, dunno.
I wouldn't add Devres just for fun. If none of the fields require it, then I wouldn't bother. Alice
