On Thu, Feb 26, 2026 at 6:56 PM Dmitry Baryshkov <[email protected]> wrote: > > On Thu, Feb 26, 2026 at 06:44:02PM +0800, Pengyu Luo wrote: > > On Wed, Feb 25, 2026 at 7:02 PM Konrad Dybcio > > <[email protected]> wrote: > > > > > > On 2/25/26 11:24 AM, Krzysztof Kozlowski wrote: > > > > On Wed, Feb 25, 2026 at 01:45:21PM +0800, Pengyu Luo wrote: > > > >> Document DSI PHY on SC8280XP Platform. > > > >> > > > >> Signed-off-by: Pengyu Luo <[email protected]> > > > >> --- > > > >> Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + > > > >> 1 file changed, 1 insertion(+) > > > >> > > > >> diff --git > > > >> a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > > > >> b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > > > >> index 9a9a6c4ab..9223af1f4 100644 > > > >> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > > > >> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > > > >> @@ -23,6 +23,7 @@ properties: > > > >> - qcom,sa8775p-dsi-phy-5nm > > > >> - qcom,sar2130p-dsi-phy-5nm > > > >> - qcom,sc7280-dsi-phy-7nm > > > >> + - qcom,sc8280xp-dsi-phy-5nm > > > > > > > > Your other commit claims it is compatible with sa8775p, just like some > > > > other devices here. > > > > > > If that helps, they do have the same values for the REVISION_ID registers > > > > > > > Thanks for confirming this,I will add this to the commit message and > > fallback to sa8775 then. > > > > I am curious, do the PHY QUIRKs in dsi_phy_7nm.c reflect PHY revision? > > Yes > > > I notice > > REG_DSI_7nm_PHY_CMN_REVISION_ID0 QUIRK > > SM8250: 0x00000014 4.1 > > SM8650: 0x00000025 5.2 > > SC8280XP: 0x00000024 4.2 > > SM8750: 0x00000027 7.0(*) > > > > (*) SM8750 is 7.2 in the downstream. > > Please change SM8750 to 7.2 (and SM8150 to 4.0 FWIW). >
ACK. It is exactly 4.0. https://github.com/OnePlusOSS/android_kernel_oneplus_sm8150/blob/oneplus/SM8150_P_9.0/arch/arm64/boot/dts/qcom/sm8150-sde.dtsi#L518 Best wishes, Pengyu
