On Tue, Mar 10, 2026 at 01:50:12PM +0100, Konrad Dybcio wrote:
> On 3/6/26 5:47 PM, Dmitry Baryshkov wrote:
> > The UBWC registers in the MDSS region are not dependent on the UBWC
> > version (it is an invalid assumption we inherited from the vendor SDE
> > driver). Instead they are dependent only on the MDSS core revision.
> >
> > Rework UBWC programming to follow MDSS revision and to use required (aka
> > encoder) UBWC version instead of the ubwc_dec_version.
> >
> > Fixes: d68db6069a8e ("drm/msm/mdss: convert UBWC setup to use match data")
> > Signed-off-by: Dmitry Baryshkov <[email protected]>
> > ---
>
> [...]
>
> > + if (data->ubwc_enc_version >= UBWC_6_0)
> > + ver = 5;
> > + else if (data->ubwc_enc_version >= UBWC_5_0)
> > + ver = 4;
> > + else if (data->ubwc_enc_version >= UBWC_4_3)
> > + ver = 3;
> > + else if (data->ubwc_enc_version >= UBWC_4_0)
> > + ver = 2;
> > + else if (data->ubwc_enc_version >= UBWC_3_0)
> > + ver = 1;
> > + else /* UBWC 1.0 and 2.0 */
> > + ver = 0;
>
> You forgot(?) to use qcom_ubwc_version_tag() later
Let me check if the patch got dropped during rebase.
>
> Konrad
--
With best wishes
Dmitry
