Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The example consumer node `sdi0_per1@80126000` will fail `dt_binding_check` validation due to missing required properties and will trigger a `dtc` warning. --
commit b98e3bf1a2da87a6966744348740e230bb97bdfd Author: Linus Walleij <[email protected]> dt-bindings: power: Convert Ux500 PM domains to schema This commit converts the legacy Ux500 power domain text binding to YAML. It moves the binding under bindings/power and updates the MAINTAINERS file accordingly. > diff --git > a/Documentation/devicetree/bindings/power/stericsson,ux500-pm-domains.yaml > b/Documentation/devicetree/bindings/power/stericsson,ux500-pm-domains.yaml > new file mode 100644 > index 0000000000000..72c39c083efbf > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/stericsson,ux500-pm-domains.yaml [ ... ] > +examples: > + - | > + #include <dt-bindings/arm/ux500_pm_domains.h> > + > + pm_domains: power-controller { > + compatible = "stericsson,ux500-pm-domains"; > + #power-domain-cells = <1>; > + }; > + > + sdi0_per1@80126000 { > + compatible = "arm,pl18x", "arm,primecell"; > + power-domains = <&pm_domains DOMAIN_VAPE>; > + }; [Severity: Low] Will this example consumer node trigger warnings during dt_binding_check? The node is matched against the arm,pl18x.yaml schema, which requires both the reg and interrupts properties. Since they are missing here, dt-schema will likely report validation errors. Additionally, because the node includes a unit address (@80126000) but lacks a reg property, does this cause dtc to emit a unit_address_vs_reg warning? Should dummy reg and interrupts properties be added to the example to satisfy the schema validation? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
