On Thu, Jun 18, 2026 at 07:00:48AM +0200, Linus Walleij wrote:
> This file has been left in an unfinished state just defining
> the root power domain for the U8500 SoC. Fix it up by adding
> the actual existing power domains in this SoC.
> 
> The PRCMU code and old regulator driver is mentioning some
> *_RET domains, this means "retention" and is a state in the
> domain and not a domain of its own.
> 
> Signed-off-by: Linus Walleij <[email protected]>

From/SoB mismatch.

> ---
>  include/dt-bindings/arm/ux500_pm_domains.h | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/include/dt-bindings/arm/ux500_pm_domains.h 
> b/include/dt-bindings/arm/ux500_pm_domains.h
> index 9bd764f0c9e6..1c168e59ac90 100644
> --- a/include/dt-bindings/arm/ux500_pm_domains.h
> +++ b/include/dt-bindings/arm/ux500_pm_domains.h
> @@ -8,8 +8,23 @@
>  #define _DT_BINDINGS_ARM_UX500_PM_DOMAINS_H
>  
>  #define DOMAIN_VAPE          0
> +#define DOMAIN_VARM          1
> +#define DOMAIN_VMODEM                2
> +#define DOMAIN_VPLL          3
> +#define DOMAIN_VSMPS1                4
> +#define DOMAIN_VSMPS2                5
> +#define DOMAIN_VSMPS3                6
> +#define DOMAIN_VRF1          7
> +#define DOMAIN_SVA_MMDSP     8
> +#define DOMAIN_SVA_PIPE              9
> +#define DOMAIN_SIA_MMDSP     10
> +#define DOMAIN_SIA_PIPE              11
> +#define DOMAIN_SGA           12
> +#define DOMAIN_B2R2_MCDE     13
> +#define DOMAIN_ESRAM_12              14
> +#define DOMAIN_ESRAM_34              15
>  
>  /* Number of PM domains. */
> -#define NR_DOMAINS           (DOMAIN_VAPE + 1)
> +#define NR_DOMAINS           (DOMAIN_ESRAM_34 + 1)

In a separate commit, instead you need to drop NR_DOMAINS and move them
to driver. If this changes, then it is not ABI. We did similarly for
many clock bindings/drivers.

Best regards,
Krzysztof

Reply via email to