On Fri, 19 Jun 2026 08:23:50 +0200 Andreas Kemnade <[email protected]> wrote:
> On Wed, 13 May 2026 16:10:14 +0300 > Tomi Valkeinen <[email protected]> wrote: > > > Drop write to SPICMR. It's unclear why the write is there, as SPI is not > > supported in the driver, and it's mostly just writing zeroes to already > > zero fields (reset defaults). None of the zero bits written disable > > anything wrt. SPI. > > > > Signed-off-by: Tomi Valkeinen <[email protected]> > > Comparing it with something out of tree where SPI is apparently working. > It does not touch SPIMR, > ok, looking what that code really does, it sets bit 1 called SPI_SEL_CS0, apparently in that register. But that belongs into an spi_init function. > so this can clearly be dropped. > So: > > Reviewed-by: Andreas Kemnade <[email protected]> Regards, Andreas
