On Mon, 22 Jun 2026 10:45:17 +0300 Tomi Valkeinen <[email protected]> wrote:
> Hi, > > On 21/06/2026 09:41, Andreas Kemnade wrote: > > On Fri, 19 Jun 2026 08:23:50 +0200 > > Andreas Kemnade <[email protected]> wrote: > > > >> On Wed, 13 May 2026 16:10:14 +0300 > >> Tomi Valkeinen <[email protected]> wrote: > >> > >>> Drop write to SPICMR. It's unclear why the write is there, as SPI is not > >>> supported in the driver, and it's mostly just writing zeroes to already > >>> zero fields (reset defaults). None of the zero bits written disable > >>> anything wrt. SPI. > >>> > >>> Signed-off-by: Tomi Valkeinen <[email protected]> > >> > >> Comparing it with something out of tree where SPI is apparently working. > >> It does not touch SPIMR, > >> > > ok, looking what that code really does, it sets bit 1 called SPI_SEL_CS0, > > apparently in that register. But that belongs into an spi_init function. > > Sorry, what sets bit 1? The write removed here just writes zeroes to a "Comparing it with something out of tree where SPI is apperntly working. I just wanted to correct my claim about SPIMR not being used there. That was not meant as an objection to this patch. Regards, Andreas
