This series adds support for the Solomon SSD1351, a 128x128 65k-color
RGB OLED controller, to the ssd130x DRM driver:
- Patch 1 adds the device tree binding.
- Patch 2 switches the SSD133X family from RGB332 to RGB565, bringing
65k color to the SSD1331.
- Patches 3 to 5 are preparatory cleanups requested on v3: constify
the ssd130x_write_data() 'values' parameter, convert
ssd130x_spi_id[] to C99 initializers, and reimplement
ssd130x_write_cmd() as a variadic wrapper around
ssd130x_write_cmds() so a single loop remains.
- Patch 6 adds the SSD1351 as a new SSD135X_FAMILY. It gets its own
primary plane update/disable, encoder enable and backlight
callbacks; only the callbacks with no family-specific logic
(ssd133x_primary_plane_atomic_check(), ssd133x_crtc_atomic_check()
and ssd130x_encoder_atomic_disable()) are reused as is. It also
sends command parameters on the data path, handled in
ssd130x_write_cmds() via a new cmd_params_are_data flag; see [2]
for why the split lives there rather than in the SPI transport.
Testing:
- Patches 1, 3, 4, 5 and 6 are tested on an SSD1351.
- The SSD1331 RGB565 change (patch 2) was kindly tested by Javier on
his SSD1331.
Thanks to Javier, Andy, Krzysztof and Fabio for the reviews.
[1] v4 of this series:
https://lore.kernel.org/dri-devel/[email protected]
[2] Command parameter path discussion:
https://lore.kernel.org/dri-devel/[email protected]
---
Changes since v4:
- Move assignment of fi and plane_state to be just before their
first use.
- Move ret variable declaration below cmds[] in ssd135x_init().
- Constify remap variable in ssd133x_init() and ssd135x_init().
- Replace ARRAY_SIZE() with sizeof() in ssd130x_write_cmd().
- Collect Andy's Reviewed-by tags on patches 3 and 4.
Amit Barzilai (6):
dt-bindings: display: Add Solomon SSD1351 OLED controller
drm/ssd130x: Change SSD133X color format to RGB565 from RGB332
drm/ssd130x: Constify ssd130x_write_data() 'values' parameter
drm/ssd130x: Replace positional ssd130x_spi_id[] initialization with
C99
drm/ssd130x: Implement ssd130x_write_cmd() on top of
ssd130x_write_cmds()
drm/ssd130x: Add SSD135X_FAMILY and SSD1351 support
.../bindings/display/solomon,ssd1351.yaml | 42 ++
drivers/gpu/drm/solomon/ssd130x-spi.c | 25 +-
drivers/gpu/drm/solomon/ssd130x.c | 420 +++++++++++++++---
drivers/gpu/drm/solomon/ssd130x.h | 10 +-
4 files changed, 432 insertions(+), 65 deletions(-)
create mode 100644
Documentation/devicetree/bindings/display/solomon,ssd1351.yaml
base-commit: 843bc34db94bff0612c8294861b156489958897b
--
2.55.0
