ssd130x_spi_id[] is initialized with positional initializers, which easily create easy-to-miss bugs when changing the members of the target struct (struct spi_device_id in this example).
Change this to C99 initializers to guarantee each member is initialized with the correct value. Signed-off-by: Amit Barzilai <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> --- drivers/gpu/drm/solomon/ssd130x-spi.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x-spi.c b/drivers/gpu/drm/solomon/ssd130x-spi.c index b52f5fd592a1..be50e5aa2c87 100644 --- a/drivers/gpu/drm/solomon/ssd130x-spi.c +++ b/drivers/gpu/drm/solomon/ssd130x-spi.c @@ -160,17 +160,17 @@ MODULE_DEVICE_TABLE(of, ssd130x_of_match); */ static const struct spi_device_id ssd130x_spi_id[] = { /* ssd130x family */ - { "sh1106", SH1106_ID }, - { "ssd1305", SSD1305_ID }, - { "ssd1306", SSD1306_ID }, - { "ssd1307", SSD1307_ID }, - { "ssd1309", SSD1309_ID }, + { .name = "sh1106", .driver_data = SH1106_ID }, + { .name = "ssd1305", .driver_data = SSD1305_ID }, + { .name = "ssd1306", .driver_data = SSD1306_ID }, + { .name = "ssd1307", .driver_data = SSD1307_ID }, + { .name = "ssd1309", .driver_data = SSD1309_ID }, /* ssd132x family */ - { "ssd1322", SSD1322_ID }, - { "ssd1325", SSD1325_ID }, - { "ssd1327", SSD1327_ID }, + { .name = "ssd1322", .driver_data = SSD1322_ID }, + { .name = "ssd1325", .driver_data = SSD1325_ID }, + { .name = "ssd1327", .driver_data = SSD1327_ID }, /* ssd133x family */ - { "ssd1331", SSD1331_ID }, + { .name = "ssd1331", .driver_data = SSD1331_ID }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(spi, ssd130x_spi_id); -- 2.55.0
