Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The newly added register `DP_PHY_LDO_CFG` is missing the `_NORD` suffix. --
commit d9b8ac1d640ce0c0f48897f46216bd9e72eb391e Author: Ritesh Kumar <[email protected]> phy: qcom: edp: Add Nord-specific register offsets This commit adds Nord-specific register offsets for the DP PHY and QSERDES v8 COM to allow Nord sequences to reference them directly by name. > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c > b/drivers/phy/qualcomm/phy-qcom-edp.c > index a3c893f72908f..bf8a17336c7ec 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c [ ... ] > @@ -41,9 +41,19 @@ > > #define DP_PHY_VCO_DIV 0x0074 > #define DP_PHY_TX0_TX1_LANE_CTL 0x007c > +/* Nord uses a different register layout; non-Nord value is 0x00a0 */ > #define DP_PHY_TX2_TX3_LANE_CTL 0x00a0 > +#define DP_PHY_TX2_TX3_LANE_CTL_NORD 0x00c0 > > +/* Nord uses a different register layout; non-Nord value is 0x00e0 */ > #define DP_PHY_STATUS 0x00e0 > +#define DP_PHY_STATUS_NORD 0x0110 > +#define DP_PHY_LDO_CFG 0x00f0 [Severity: Low] The commit message notes this patch adds Nord-specific defines, and other newly introduced registers appropriately use a _NORD suffix (like DP_PHY_STATUS_NORD and DP_PHY_TX_LN0_DRV_LVL_NORD). Does DP_PHY_LDO_CFG also need the _NORD suffix here? Leaving it off makes it appear as a generic register rather than a Nord-specific one. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=7
