Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] drm/todo: premature removal of drmm_of_get_bridge() with remaining vc4 callers --
commit 73f1f37bf0d85f99c672e8364cc4d9cbf3a65321 Author: Luca Ceresoli <[email protected]> drm/todo: remove drmm_of_get_bridge() This commit removes drmm_of_get_bridge() from the list of deprecated panel_bridge functions to remove in the DRM TODO documentation. > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index a437ae5c71f47..a2500418ff2ef 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -494,7 +494,6 @@ transparently, and the are deprecated. > The funcions to remove are: > - drm_panel_bridge_add_typed() > - devm_drm_of_get_bridge() > - - drmm_of_get_bridge() > - drm_panel_bridge_remove() > - drmm_drm_panel_bridge_release() > - devm_drm_panel_bridge_release() [Severity: Medium] Is it premature to remove drmm_of_get_bridge() from the TODO list and the kernel? Two unconverted callers remain in the VC4 driver: vc4_dpi_init_bridge() in drivers/gpu/drm/vc4/vc4_dpi.c and vc4_dsi_bind() in drivers/gpu/drm/vc4/vc4_dsi.c. With drmm_of_get_bridge() removed in commit "drm/panel: remove drmm_of_get_bridge()", building with CONFIG_DRM_VC4 enabled fails until those callers are converted as well. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/20261106-drm-panel_bridge-remove-drmm_of_get_bridge-v1-0-c0ea3382b...@bootlin.com?part=3
