Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] drm/i915/vrr: Signed-off-by trailer uses handle instead of real full name --
commit 6f78fb0ff83ff8c9f4f0ac58ba24164db71f007e Author: ElXreno <[email protected]> > drm/i915/vrr: Leave the transcoder to the joiner primary > > All joined pipes run off the transcoder of the primary, and the crtc > states of the secondaries are copies of the primary's state, the VRR > state included. The commit therefore reaches the transcoder level VRR > functions for every joined pipe: intel_pre_update_crtc() calls > intel_vrr_set_transcoder_timings() for each crtc whose VRR parameters > changed, intel_pre_plane_update() and commit_pipe_post_planes() call > intel_vrr_disable() and intel_vrr_enable(), and both commit paths > call intel_vrr_send_push() and intel_vrr_check_push_sent() per crtc. > > Do these once, from the primary. When disabling VRR also switch the > active timings of all joined pipes as soon as the transcoder has left > VRR mode, rather than leaving the secondaries on the VRR timings > until their own turn comes. > > The check in intel_vrr_set_transcoder_timings() drops the second, > identical programming of the transcoder that a joined fixed refresh > rate configuration gets today. Everything else depends on vrr.enable, > which is never set with the joiner yet, so there is no other > functional change. In particular the push a secondary sends for the > PSR and Panel Replay frame change is left as it is. > > The checks in intel_vrr_set_transcoder_timings(), intel_vrr_send_push(), > intel_vrr_enable() and intel_vrr_disable() are the ones Ankit Nautiyal > posted in "drm/i915/vrr: Handle joiner with vrr", last in [1]. > > [1] > https://lore.kernel.org/intel-gfx/[email protected]/ > > Suggested-by: Ankit Nautiyal <[email protected]> > Signed-off-by: ElXreno <[email protected]> [Severity: High] The Signed-off-by trailer uses a single-word handle ("ElXreno") rather than a real full name, which does not meet the Developer's Certificate of Origin requirements in Documentation/process/submitting-patches.rst. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
