intel_vrr_compute_vmax() multiplies crtc_clock, which is in kHz, by 1000 in a signed int. A 3840x2400@240 timing has a 2342.4 MHz pixel clock, so the product overflows, the quotient turns negative and vmax is clamped to crtc_vtotal. vmin then equals vmax and VRR is never enabled for the mode, although it is within the range of the panel.
Do the multiplication in 64 bits. No Fixes tag: intel_vrr_compute_vmax() is only called for a mode within the VRR range, such a pixel clock needs the joiner, and intel_vrr_compute_config() takes joined modes out of the range so far. Signed-off-by: ElXreno <[email protected]> --- drivers/gpu/drm/i915/display/intel_vrr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c index e59345bd1d33..a5a5d11380a4 100644 --- a/drivers/gpu/drm/i915/display/intel_vrr.c +++ b/drivers/gpu/drm/i915/display/intel_vrr.c @@ -416,8 +416,8 @@ int intel_vrr_compute_vmax(struct intel_connector *connector, const struct drm_display_info *info = &connector->base.display_info; int vmax; - vmax = adjusted_mode->crtc_clock * 1000 / - (adjusted_mode->crtc_htotal * info->monitor_range.min_vfreq); + vmax = div_u64(mul_u32_u32(adjusted_mode->crtc_clock, 1000), + adjusted_mode->crtc_htotal * info->monitor_range.min_vfreq); vmax = max_t(int, vmax, adjusted_mode->crtc_vtotal); return vmax; -- 2.56.0
