Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] drm/i915/panel: commit Signed-off-by trailer uses handle instead of real name --
commit a81f42546a1b676a6932361ec102d9c524823aa2 Author: ElXreno <[email protected]> > drm/i915/panel: Fix the pixel clock overflow in the VRR vtotal > > intel_panel_compute_config_vrr() multiplies the pixel clock in kHz by > 1000 in a signed int. A 3840x2400@240 timing has a 2342.4 MHz pixel > clock, the product overflows, and the vertical total computed for a > refresh rate other than that of the fixed mode comes out negative. > > Do the multiplication in 64 bits. > > This needs a fixed mode above 2147 MHz, so one that uses the joiner, > inside the VRR range of the panel, and a request for another refresh > rate that ends up on that fixed mode, as the allow_modeset=false path > does for a mode that is VRR compatible with the current one. > > Fixes: a2da67028cd0 ("drm/i915: Allow arbitrary refresh rates with VRR eDP > panels") > Signed-off-by: ElXreno <[email protected]> [Severity: High] Both the Author header and the Signed-off-by trailer use the single-word handle ElXreno rather than a real full name. Documentation/process/submitting-patches.rst requires contributors to sign off using a known real identity under the Developer's Certificate of Origin rather than a pseudonym or handle. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
