On Thu, Dec 27, 2001 at 12:43:03PM -0800, Gareth Hughes wrote: > On Thu, Dec 27, 2001 at 03:27:07AM -0800, Philip Brown wrote: > >... > > I did a whole lot of global grepping through files. > > FINALLY, I figured out that it was in xf86drmHash.c, hidden from the ctags > > program because of the funky > > #define N(x) drm##x > > > > WHY is that there? I can find no reason for it, and it greatly hinders > > peole's understanding of the code, since it breaks both greps and ctags. > > How about getting rid of that dumb #define hack in the next release? > > If you can think of a way of including the common files in each driver, > and building some drivers into the kernel and some as modules and having > it all Just Work, please feel free to share your ideas with the list.
I am specifically talking about xf86drmHash.c here. Where does it get "included"? do you mean #include, or just linking? As far as I can see, the 'N()' define never gets redefined. It is defined in xf86drmHash.c, gets used in xf86drmHash.c, and as far as that specific file, I dont see it changing anywhere. Can you tell me where it does get changed, specifically for xf86drmHash.c? _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
