Leif Delgass wrote: > On Wed, 17 Jul 2002, Keith Whitwell wrote: > > >>Leif Delgass wrote: >> >>>On Wed, 17 Jul 2002, Leif Delgass wrote: >>> >>> >>> >>>>On 17 Jul 2002, Michel Dänzer wrote: >>>> >>>> >>>> >>>>>On Wed, 2002-07-17 at 20:05, Keith Whitwell wrote: >>>>> >>>>> >>>>>>I've fixed this for drivers that use t_dd_triemit.h -- currently only radeon >>>>>>and r200. >>>>>> >>>>>> >>>>>Great job! The clipping problems I originally reported with the >>>>>xscreensaver gears hack and fsv are fixed. >>>>> >>>>> >>>>I've applied this fix to the mach64 FastRenderClippedPoly function and >>>>reverted my previous fix. >>>> >>>>I've tested the fix on r128 and it works there as well. It looks like it >>>>needs to be applied to all drivers with the FastRenderClippedPoly >>>>function, but I can't test any of the other drivers. >>>> >>>>There's another fix I made to the mach64 driver that I think needs to be >>>>applied to all drivers, and that's setting the read buffer equal to the >>>>draw buffer when switching draw buffers. This fixes software fallbacks >>>>when drawing on the front buffer. I've tested it on r128 and it works. >>>>Should I try my hand at combining these into a single patch for all the >>>>drivers? >>>> >>>At any rate, the patch for r128 with the read buffer + flatshade fix is >>>attached. If nobody has any objections, I can commit this. Maybe someone >>>with access to other cards would like to try making the changes for other >>>drivers? >>> >>I've done all the others. Lets see if testing was required... >> > > So, should I commit the fix for r128? I've tested that and it works fine.
Yes, go ahead. > I took a look at the other drivers concerning the read buffer fix. It > looks like mga, i810, and i830 already do this correctly. Reading from a > separate read buffer doesn't seem to be implemented on tdfx and sis. It > looks like ffb, gamma, r128, and radeon need the fix. The attached patch > has fixes for all the drivers except sis (I included tdfx even though the > ReadBuffer isn't used). I've tested the read buffer fix on mach64 and > r128 with texenv (single-buffer mode), checking to see that textures done > in software are correctly blended with the front buffer when the > background is turned off (the checker-board should show through in the > transparent areas). You'd have to force a fallback to test this on Radeon > or other drivers without texture fallbacks. Sounds good - go ahead & commit this to. Keith ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
