Hi guys,
1) We still need password/username. Those will return eventually so
there is no reason to pull them right now.
Done. They're back in.
2) The set-variable, socket, and protocol can be deleted (protocol
can be hard wired). Check to see if verbose is still doing anything.
Done. Verbose is working as expected and I added couple of verbose
output for shutdown while I was at it.
Here is the changeset:
http://bazaar.launchpad.net/~dev-torum/drizzle/mysqladmin_diet/revision/156
The mysqladmin behavior was also changed to speak TCP, as mentioned by
Mark. I also got rid of unix socket related code that was in
mysqladmin (since we're going to ditch it in drizzle).
Cheers,
Toru
On Jul 15, 2008, at 1:07 AM, Brian Aker wrote:
Hi!
Thanks!
A couple of comments:
1) We still need password/username. Those will return eventually so
there is no reason to pull them right now.
2) The set-variable, socket, and protocol can be deleted (protocol
can be hard wired). Check to see if verbose is still doing anything.
All good, other then that.
Cheers,
-Brian
On Jul 14, 2008, at 4:50 AM, Toru Maesaka wrote:
Hi guys,
So I was intending on getting rid of mysqladmin but after talking
to Brian, it was slimmed down to only 'shutdown' and 'ping'. This
is a temporary fix until we have a better alternative (e.g.
drizzlectl, drizzleping, drizzlestop, and etc).
While I was at it, I got rid of some dead code in libdrizzle/
password.c that I found is only used by the deleted mysqladmin
code. Think they're password related stuff from the older MySQL
version.
Here is the changeset:
http://bazaar.launchpad.net/~dev-torum/drizzle/mysqladmin_diet/revision/155
and the branch:
https://code.launchpad.net/~dev-torum/drizzle/mysqladmin_diet
Would be awesome if I could get some comments :)
Cheers,
Toru
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
--
_______________________________________________________
Brian "Krow" Aker, brian at tangent.org
Seattle, Washington
http://krow.net/ <-- Me
http://tangent.org/ <-- Software
_______________________________________________________
You can't grep a dead tree.
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
