Hi!

I'm going over the MyISAM code to eliminate pointless casts (I hate
casts), and am stumbling over several cases where there is "(uint) (end
-  something)".  This can only work if end > something, so the cast is
pointless and I will remove it, but the problem is that in the event
that end < something (perhaps because of a bug), this will copy a very
large amount of data. I want to add assertions for those cases, but are
we going to keep using DBUG_ASSERT() or will be go back to standard
assert()?

Just asking for opinions,
Mats Kindahl
-- 
Mats Kindahl
Lead Software Developer
Replication Team
MySQL AB, www.mysql.com
begin:vcard
fn:Mats Kindahl
n:Kindahl;Mats
org:Sun Microsystems
adr;quoted-printable:;;Tegv=C3=A4gen 3;Storvreta;SE;74334;Sweden
email;internet:[EMAIL PROTECTED]
title:Lead Replication Software Developer
x-mozilla-html:FALSE
version:2.1
end:vcard

_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp

Reply via email to