Mats Kindahl wrote:
> Hi!
> 
> I'm going over the MyISAM code to eliminate pointless casts (I hate
> casts), and am stumbling over several cases where there is "(uint) (end
> -  something)".  This can only work if end > something, so the cast is
> pointless and I will remove it, but the problem is that in the event
> that end < something (perhaps because of a bug), this will copy a very
> large amount of data. I want to add assertions for those cases, but are
> we going to keep using DBUG_ASSERT() or will be go back to standard
> assert()?

Standard assert. DBUG is dead.

Our configure script now supports the --disable-assert option to set the
standard NDEBUG flag and make asserts in to no-ops. However, we're
talked about keeping asserts on as a general rule. Not sure where the
final word was on this.

_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp

Reply via email to