[
http://jira.dspace.org/jira/browse/DS-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11192#action_11192
]
Tim Donohue commented on DS-483:
--------------------------------
From discussion during DSpace Developers Mtg on Feb 17 2010 (
http://www.duraspace.org/irclogs/index.php?date=2010-02-17 )
[16:16] <tdonohue> http://jira.dspace.org/jira/browse/DS-483 :
statistics.item.authorization.admin ignored by xmlui
[16:17] <kshepherd> so, this seems to be either a typo in the xmlui stats when
it does the getProperty for statistics.item.authorization.admin
[16:17] <kshepherd> OR.. ben has assumed the opposite of what i assumed when we
looked at 'statistics.item.authorization.admin'
[16:17] <kshepherd> my understanding was that this meant "admin-only access for
stats"
[16:17] <tdonohue> yea, that'd be my assumption as well.... "true" means
admin-only
[16:17] <kshepherd> which is why JSPUI blocks non-admins from viewing if
statistics.item.authorization.admin=true
[16:18] <kshepherd> but this is still quite an ambiguous parameter
[16:18] <kshepherd> statistics.public = false would be better, imho
[16:18] <tdonohue> yea, the parameter is badly named in general...it has
nothing to do with "item" for one
[16:18] <mhwood> Community discussion on what this ought to mean, or what it is
that people want to configure?
[16:19] <kshepherd> mhwood: what people feel is more intuitive when they're
editing dspace.cfg for the first time, i guess..
[16:19] <tdonohue> I think we know what it currently means. It enables/disables
whether stats are public vs. admin-only.
[16:19] <kshepherd> here's the XMLUi code that ignores it
[16:19] <kshepherd>
http://scm.dspace.org/svn/repo/dspace/trunk/dspace-xmlui/dspace-xmlui-api/src/main/java/org/dspace/app/xmlui/aspect/statistics/StatisticsAuthorizedMatcher.java
[16:20] <tdonohue> what peopole want to configure is another question (cause it
could be a lot of things), and it's post 1.6.0 :)
[16:20] <kshepherd> ok, sure, lets not worry about the wording
[16:20] <tdonohue> kshepherd: Can you work to sync that code up with JSPUI
code, since you know this well?
[16:21] <kshepherd> it's kidna confusing, actually
[16:21] <kshepherd> quite different to my jspui implementation
[16:21] <tdonohue> oh, ok.
[16:21] <kshepherd> i know the backend stats api code, and the jspui, but not
the xmlui stuff :/
[16:21] <kshepherd> can i paste big here? ;)
[16:22] <tdonohue> I'll send an email to ben bosman and mdiggory about this
then...see if one of them will fix it to work the same as JSPUI for now
[16:22] <kshepherd> ok
[16:22] <tdonohue> DS-483 : Tim will contact @mire for a fix
> statistics.item.authorization.admin ignored by xmlui
> ----------------------------------------------------
>
> Key: DS-483
> URL: http://jira.dspace.org/jira/browse/DS-483
> Project: DSpace 1.x
> Issue Type: Bug
> Components: JSPUI, XMLUI
> Affects Versions: 1.6.0
> Reporter: Claudia Jürgen
> Priority: Trivial
>
> The statistics.item.authorization.admin is meanwhile taken into account for
> the jspui see
> DS-409, but the xmlui still makes the statistics accessible regardless of the
> configuration.
> Furthermore if the stats are enable for authorized only then the "View
> statistics" links should not be displayed if the user is no admin.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
