[
http://jira.dspace.org/jira/browse/DS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11323#action_11323
]
Robin Taylor commented on DS-546:
---------------------------------
Hi Mark,
Not sure its the same thing. This is the comment at the top of the class....
* This class will add a simple notification div the DRI document. Typicaly
* this transformer is used after an action has been preformed to let the
* user know if an operation succeded or failed.
Its used throughout the Admin aspect to notify the user of things like 'Group
Successfully Added'. Unfortunately if I invoke it in another aspect the content
appears twice because it always gets invoked in the Admin aspect. I think it
should only get invoked in the Admin aspect if the content was generated in the
Admin aspect.
Unless anyone objects I would like to leave this issue open as a reminder to
myself. I will assign it to me so that its not continually being reviewed.
> XMLUI 'Notice's are always added by the Administrative aspect even if the
> content was generated by another aspect.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: DS-546
> URL: http://jira.dspace.org/jira/browse/DS-546
> Project: DSpace 1.x
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.5.2
> Reporter: Robin Taylor
> Priority: Minor
>
> Not sure if this qualifies as a bug. I am looking for some comments or
> advice...
> The XMLUI has a utility class
> org.dspace.app.xmlui.aspect.general.NoticeTransformer that facilitates
> adding a simple 'Notice' div to a page. Unfortunately this transformer is
> always invoked by the Administrative sitemap...
> <map:match type="WildcardParameterMatcher" pattern="true">
> <map:parameter name="parameter-name" value="notice"/>
> <map:parameter name="notice" value="{flow-attribute:notice}"/>
> <map:transform type="notice">
> This prevents the reuse of NoticeTransformer in other aspects and breaks
> the notion of each aspect being independent. Either the class should be
> moved out of the 'general' package and into an 'administrative' package, or,
> the class should only be invoked in the Administrative sitemap if the content
> was generated in the Administrative aspect. This could be achieved by adding
> a match against the url ...
> <map:match pattern="admin/**">
> This would be my preferred option but it might break any customisations that
> have been done relying on the fact that the Admin aspect would always add any
> Notices.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
