[
http://jira.dspace.org/jira/browse/DS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11584#action_11584
]
Tim Donohue commented on DS-546:
--------------------------------
Robin,
Will this fix be ready for 1.7? If so, please change the 'fix for version' to
1.7.
We briefly discussed this in today's Dspace devel meeting -- It sounds like you
and Mark have a handle on what is going on (and how to potentially resolve it).
Let us know if you need more feedback/help.
[20:14] <tdonohue> XMLUI 'Notice's are always added by the Administrative
aspect even if the content was generated by another aspect. :
http://jira.dspace.org/jira/browse/DS-546
[20:15] <tdonohue> robin taylor has already claimed this one...so, I'll assume
he's working on it
[20:16] <tdonohue> I'd vote to schedule this for 1.7 though -- it sounds like
mdiggory & rtaylor have a good handle on it
[20:16] <richardrodgers> yep +1 if Robin has it sorted
[20:16] <tdonohue> I'll schedule DS-546 for 1.7, and touch base with Robin
> XMLUI 'Notice's are always added by the Administrative aspect even if the
> content was generated by another aspect.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: DS-546
> URL: http://jira.dspace.org/jira/browse/DS-546
> Project: DSpace 1.x
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.5.2
> Reporter: Robin Taylor
> Assignee: Robin Taylor
> Priority: Minor
>
> Not sure if this qualifies as a bug. I am looking for some comments or
> advice...
> The XMLUI has a utility class
> org.dspace.app.xmlui.aspect.general.NoticeTransformer that facilitates
> adding a simple 'Notice' div to a page. Unfortunately this transformer is
> always invoked by the Administrative sitemap...
> <map:match type="WildcardParameterMatcher" pattern="true">
> <map:parameter name="parameter-name" value="notice"/>
> <map:parameter name="notice" value="{flow-attribute:notice}"/>
> <map:transform type="notice">
> This prevents the reuse of NoticeTransformer in other aspects and breaks
> the notion of each aspect being independent. Either the class should be
> moved out of the 'general' package and into an 'administrative' package, or,
> the class should only be invoked in the Administrative sitemap if the content
> was generated in the Administrative aspect. This could be achieved by adding
> a match against the url ...
> <map:match pattern="admin/**">
> This would be my preferred option but it might break any customisations that
> have been done relying on the fact that the Admin aspect would always add any
> Notices.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
This SF.net email is sponsored by
Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
