[
http://jira.dspace.org/jira/browse/DS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11326#action_11326
]
Mark Diggory commented on DS-546:
---------------------------------
Ah, I misunderstood and thought we were talking about System Wide Alerts. You
are right that this is not the same class.
Reviewing things closer, I started to make a recommendation is to do exactly
what you suggest, qualifying it with an "/admin/". Thinking the reason for
doing so is that where this matcher is used is in the midst of the flowscript
and so this needs to be present exactly in this location to catch the notices
coming out of flowscript activities. But the fact that you activate it from
your own aspects suggests it does not need to be embeeded here and could go in
he generic Aspect. I think we should explore trying to place it there... don't
worry about breaking customizations, I do not think at this level it would and
we would like to know who would be customizing that this level and why because
they should probably be a "committer" and doing it in the community. ;-)
<!-- Flow pages
These pages may only be reached through
a flow script. While typicaly all
the user sees in their url bar is a
short url like /admin/epeople or
/admin/groups, in reality there is
another url being used. The flow scripts
always operate on these simple url, but
once the particular state is determined
an distinquising part is appended to
the url for the particular state. Below are
all those url.
-->
<map:match type="WildcardParameterMatcher"
pattern="true">
<map:parameter name="parameter-name"
value="flow"/>
<map:parameter name="flow"
value="{flow-attribute:flow}"/>
> XMLUI 'Notice's are always added by the Administrative aspect even if the
> content was generated by another aspect.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: DS-546
> URL: http://jira.dspace.org/jira/browse/DS-546
> Project: DSpace 1.x
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.5.2
> Reporter: Robin Taylor
> Assignee: Robin Taylor
> Priority: Minor
>
> Not sure if this qualifies as a bug. I am looking for some comments or
> advice...
> The XMLUI has a utility class
> org.dspace.app.xmlui.aspect.general.NoticeTransformer that facilitates
> adding a simple 'Notice' div to a page. Unfortunately this transformer is
> always invoked by the Administrative sitemap...
> <map:match type="WildcardParameterMatcher" pattern="true">
> <map:parameter name="parameter-name" value="notice"/>
> <map:parameter name="notice" value="{flow-attribute:notice}"/>
> <map:transform type="notice">
> This prevents the reuse of NoticeTransformer in other aspects and breaks
> the notion of each aspect being independent. Either the class should be
> moved out of the 'general' package and into an 'administrative' package, or,
> the class should only be invoked in the Administrative sitemap if the content
> was generated in the Administrative aspect. This could be achieved by adding
> a match against the url ...
> <map:match pattern="admin/**">
> This would be my preferred option but it might break any customisations that
> have been done relying on the fact that the Admin aspect would always add any
> Notices.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
