[
https://jira.duraspace.org/browse/DS-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18440#action_18440
]
Kim Shepherd commented on DS-640:
---------------------------------
I don't feel this patch will be ready in time for 1.7.0, given that it needs a
fair bit of dedicated testing..
It should be noted that JSPUI currently *does* default a missing or invalid
?type to the default browse index. This is different to the initial description
of the problem. The only change we'd need to make is to remove the "default to
first browse index" behaviour happen on /browse?type=missing and
/browse?foo=bar and respond with 400 instead.
In the case of XMLUI, I'm successfully throwing an IllegalArgumentException and
setting http response code to 400, but the /browse defaulting will take some
more time to perfect, and the 404s are still being affected by the Cocoon bug
that causes them to end up as 200 OK responses (which, it could be argued, is
worse than a 500 status when it comes to giving meaningful responses to Google).
So I recommend that I keep at it, upload a patch once I have a complete example
for XMLUI and JSPUI, and we fix this in 1.7.1 with plenty of testing beforehand.
Apologies this wasn't done in time for 1.7.0.
> Interal System Error when browsing with wrong argument
> ------------------------------------------------------
>
> Key: DS-640
> URL: https://jira.duraspace.org/browse/DS-640
> Project: DSpace
> Issue Type: Bug
> Components: JSPUI, XMLUI
> Affects Versions: 1.5.2, 1.6.0, 1.6.1, 1.6.2
> Reporter: Hardik Mishra
> Assignee: Kim Shepherd
> Priority: Major
> Attachments: browse.patch
>
>
> On Browsing Items:
> If someone tries to use browse type for which browse index does not exist,
> like browse=publisher
> e.g. http://dspace.webinito.com/browse?type
> OR
> e.g. http://dspace.webinito.com/browse?type=xyz
> You will get Internal System Error
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
