[
https://jira.duraspace.org/browse/DS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=19492#action_19492
]
Tim Donohue commented on DS-724:
--------------------------------
This issue was discussed in Developer Meeting on March 9, 2011:
[20:15] <PeterDietz> https://jira.duraspace.org/browse/DS-724
createAdministrators() and createSubmitters() should not add policies if the
associated group already exists
[20:16] <richardrodgers> has anyone looked at patch DS-724?
[20:16] <tdonohue> +1 to DS-724, this sounds like a bug to me. Needs a
volunteer to analyze & test patch
[20:16] <kshepherd> i'm not sure of the patch, but the issue is reasonable
[20:16] <robint> Not sure if this is a bug.
[20:16] <robint> There is an arguement for always having uniquely named groups
associated with collections
[20:17] <PeterDietz> the patch is weird to read since the code was just moved
out of an if block
[20:17] <robint> and then add other common groups ijnto those groups.
[20:17] <kshepherd> there doesn't seem to be any test to check for
pre-existence of the groups?
[20:17] <kshepherd> ah, true
[20:17] <robint> If you allow common groups you will get Exceptions elsewhere
[20:17] <robint> eg when you try and delete a collection.
[20:17] <tdonohue> any volunteer to analyze this further & comment/report back
on whether or not this is a bug?
[20:17] <mhwood> Then Delete needs to be fixed.
[20:18] <robint> mhwood: possibly true.
[20:18] <robint> I'll take it
[20:18] <stuartlewis> Summary: +1, needs more analysis. Assign to robint.
> createAdministrators() and createSubmitters() should not add policies if the
> associated group already exists
> ------------------------------------------------------------------------------------------------------------
>
> Key: DS-724
> URL: https://jira.duraspace.org/browse/DS-724
> Project: DSpace
> Issue Type: Bug
> Components: DSpace API
> Affects Versions: 1.6.2
> Reporter: Andreas Schwander
> Assignee: Robin Taylor
> Attachments: Collection.patch
>
>
> New policies will be created when the methods createAdministrators() and
> createSubmitters() in org.dspace.content.Collection will be called even if
> the administrators or the submitters group already exists.
> These methods should just return the group if one exists and should not
> update the database or add policies.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software
be a part of the solution? Download the Intel(R) Manageability Checker
today! http://p.sf.net/sfu/intel-dev2devmar
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
