[ 
https://jira.duraspace.org/browse/DS-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24394#comment-24394
 ] 

Ivan Masár edited comment on DS-1084 at 5/9/12 1:58 PM:
--------------------------------------------------------

I tested with the latest version you attached.

I no longer have any NPE problems.

I was able to export and reimport my whole repository successfully, even when 
DOI contained "::".

To address the last problem, I configured
authority.controlled.dc.contributor.author = true
but despite the documentation says I should, I DIDN'T configure 
choices.plugin.dc.contributor.author because I don't want to create a choices 
plugin. Authorities are looked up manually when editing the CSV file, I don't 
use the sumbission process (and I didn't test it, either). Import/export worked 
correctly in my case.

BUT

As I wrote before, when authority.controlled.dc.contributor.author is not set 
(which is the default configuration), the import tool says it adds the 
authority, but it doesn't actually do it. That's a problem for 2 reasons:
1) what it writes it does is actually not true
2) it's not backwards-compatible with an older dspace.cfg and contribution 
guidelines strongly recommend to keep backwards compatibility

Perhaps it would be best if metadata-import first checked the value of 
authority.controlled.xyz and if it's not true or not present, it would either:
1) print a warning if you're trying to add authority, or
2) ignore the authority values silently, or
3) bypass the check and add authority anyway (I know it doesn't do any harm, I 
tested adding authorities manually without enabling authority.controlled.xyz)
but it really shouldn't write that it added authority when it really didn't.
                
      was (Author: helix84):
    I tested with the latest version you attached.

I no longer have any NPE problems.

I was able to export and reimport my whole repository successfully, even when 
DOI contained "::".

To address the last problem, I configured
authority.controlled.dc.contributor.author = true
but despite the documentation says I should, I DIDN'T configure 
choices.plugin.dc.contributor.author because I don't want to create a choices 
plugin. Authorities are looked up manually when editing the CSV file, I don't 
use the sumbission process (and I didn't test it, either). Import/export worked 
correctly in my case.

BUT

As I wrote before, when authority.controlled.dc.contributor.author is not set 
(which is the default configuration), the import tool says it adds the 
authority, but it doesn't actually do it. That's a problem for 2 reasons:
1) what it writes it does is actually not true
2) it's not backwards-compatible with an older dspace.cfg and contribution 
guidelines strongly recommend to keep backwards compatibility

Perhaps it would be best if metadata-import first checked the value of 
authority.controlled.xyz and if it's not true or not present, it would either:
1) print a warning if you're trying to add authority, or
2) ignore the authority values silently, or
3) bypass the check and add authority anyway (I know it doesn't do any harm, I 
tested adding authorities manually without enabling authority.controlled.xyz)
but it really shouldn't write that added authority when it really didn't.
                  
> Handle authority and confidence fields in Bulk Editing
> ------------------------------------------------------
>
>                 Key: DS-1084
>                 URL: https://jira.duraspace.org/browse/DS-1084
>             Project: DSpace
>          Issue Type: Improvement
>          Components: DSpace API
>    Affects Versions: 1.8.0
>            Reporter: Keiji Suzuki
>            Assignee: Robin Taylor
>         Attachments: bulkedit-authority.patch, bulkedit-patches.zip, 
> MetadataImport.java, MetadataImport.java.patch
>
>
> Current bulk editing function ignores authority and confidence fields. 
> Attached patches (against to 1.8.0 sources) handle these fields.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to