Thanks Andrea;

Excellent analysis of the problem. Being fiercely vigilant about blank 
value handling logic in the item-view.xsl file does indeed result in zero 
aberrancies to the display. The link to Mirage's item-view.xsl was 
inspired. However, I do NOT believe that file is currently vigilant enough 
to fully remove irregularities. E.g., line 124 
<https://github.com/DSpace/DSpace/blob/master/dspace-xmlui/src/main/webapp/themes/Mirage/lib/xsl/aspect/artifactbrowser/item-view.xsl#L124>
 
would loop through as many blank dc.title records as one may have and 
display line breaks and semicolons for each. Not cool.

In my limited experience, to fix your display when blank values mess with 
it, you'll need to add "...and descendant::text()" to *every* "xsl:when 
test", "xsl:for-each" and "xsl:if test".
It is important to add it once to *every *dim:field[...] statement for 
those three control statements -- and maybe others if you run across them.

The handling of blank values needs to be that robust because you may never 
know where the blank one could be -- one or more can crop up first, last, 
or in the middle somewhere.

Being very new to xsl coding, I can't tell you for sure the way to handle 
every conditional (or even if this is proper) but if you have a weird 
display symptom and you find a blank metadata value, this is likely the 
kind of fix you'll need to implement as well.

Vote for Bram's task if you haven't 
already: https://jira.duraspace.org/browse/DS-1685. I don't think blank 
values help anyone -- but I could be wrong...

Thanks everyone! The item display problem is resolved in all cases for us 
-- now that I have made these changes to item-view.xsl.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"DSpace Technical Support" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/dspace-tech.
For more options, visit https://groups.google.com/d/optout.

Reply via email to