THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#322 - remove superfluous "Dumux::"
User who did this - Bernd Flemisch (bernd)
----------
Compare
typedef Dumux::FluidSystems::LiquidPhase<Scalar, Dumux::H2O<Scalar> > type;
with
typedef FluidSystems::LiquidPhase<Scalar, H2O<Scalar> > type;
or
SET_TYPE_PROP(OnePNIConductionProblem, Fluid,
Dumux::FluidSystems::LiquidPhase<typename GET_PROP_TYPE(TypeTag,
Scalar),
Dumux::H2O<typename
GET_PROP_TYPE(TypeTag, Scalar)> >);
with
SET_TYPE_PROP(OnePNIConductionProblem, Fluid,
FluidSystems::LiquidPhase<typename GET_PROP_TYPE(TypeTag, Scalar),
H2O<typename GET_PROP_TYPE(TypeTag,
Scalar)> >);
To me, the lines without "Dumux::" are quite a bit better to read. I also would
say that most names in Dumux that aren't qualified by "Dune::" or "std::" are
from the namespace Dumux.
If removing yields an error, the occurrence is not superfluous.
----------
More information can be found at the following URL:
http://www.dumux.org/flyspray/index.php?do=details&task_id=322#comment688
You are receiving this message because you have requested it from the Flyspray
bugtracking system. If you did not expect this message or don't want to
receive mails in future, you can change your notification settings at the URL
shown above.
_______________________________________________
Dumux mailing list
Dumux@listserv.uni-stuttgart.de
https://listserv.uni-stuttgart.de/mailman/listinfo/dumux
