THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#322 - remove superfluous "Dumux::"
User who did this - Timo Koch (timokoch)

----------
I think the Dune:: prefix here was actually wrong / less general. It think it 
doesn't work with grids placed in another namespace than Dune because Dune 
intended to make that work through ADL.

Nevertheless we should probably make it consistent. I actually find your first 
example more readable. Our problem are always implemented in their own header 
which we put in the Dumux namespace. In a cc file however I would personally 
not put anything in a namespace and always use the correct namespace specifier. 
As problem and spatial params are kind of our cc file extensions
I would personally make it clear there where things come from, although it 
should be already clear given the namespace...
No strong opposition here.

I think we can discuss this and execute changes at the next Dumux day?


----------

More information can be found at the following URL:
http://www.dumux.org/flyspray/index.php?do=details&task_id=322#comment691

You are receiving this message because you have requested it from the Flyspray 
bugtracking system.  If you did not expect this message or don't want to 
receive mails in future, you can change your notification settings at the URL 
shown above.
_______________________________________________
Dumux mailing list
[email protected]
https://listserv.uni-stuttgart.de/mailman/listinfo/dumux

Reply via email to