Hi,

Am Mittwoch, 25. Juli 2007 18:43 schrieb Michael Riepe:
> >>As long as you have (ba)sh and a few tools...
> >
> > Of course,... but that's no problem under Linux and Windows with
> > MinGW/MSYS.
>
> Older versions of bash (i.e. bash2) have problems, and some other Bourne
> compatible shells may fail as well.
>
> I'm working on that.

Ups, you're right... I didn't thought of ancient shells... also under MinGW I 
already had to change the #!/bin/bash to #!/bin/sh (whatever shell this is)
to make it work.

>
> >>>Additionally in that header file a version string containing the last
> >>>official release is set, which is got from the envirionment variable
> >>>$VERSION, some text file "version.txt", a pre-build header file or some
> >>>default set in the script (in that order!).
> >>
> >>Ugh. That's a bit too much. ;-)
> >
> > Just to have the choice and play a bit with different options... ;-)
>
> I think we should skip $VERSION.

No problem,... my first atempt was to set the version in the Makefile
but than I realized that this ain't a good idea since we also would have to 
set it in SConstruct.

> >>setversion should not modify a file that comes from the repository.
> >>Otherwise, I might check in the modified version by mistake.
> >
> > OK,... than we are fine with a simple text file  named "version.txt" in
> > the top directory which just contains the string "0.5.4".
>
> I'll rename that file to VERSION, if you don't mind.

That's why I've made it configureable via the variable VERSION_FILE.... ;-)

>
> > Hhmmm,... maybe it's a good idea to put it under version control, i.e.
> > allow for a comment line containing $Id$ and scan it also additionally by
> > setversion?
>
> Version control - yes. $Id$ line - not sure.

When you just commit/change this file alone, setversion wouldn't get the 
correct revision after checkout if there's no $Id$-line...

OK, the same thing holds for the *.ui files,... but Ihope that you always will 
change some other files additionally to these... ;-)

>
> > In case one "declares" an official version just by changing the text
> > file.... I attached an updated script allowing comments (and with a small
> > bug fix)!
>
> Maybe we should check for a .svn subdirectory. If none exists, the
> sources probably come from a release tarball.
>
Is that a problem?
Will the source files in a release tarball not contain the resolved 
$id:-lines? Or don't you want to have a revision number printed
in the dvdcut caption for "released" versions?

> [...]
>
> >>You probably forgot to tell make that dvbcut.cpp now depends on
> >>version.h - if you don't, it will simply ignore any changes to the file.
> >
> > Hmmm, .... are the include files not checked automatically?
> > Also a "make dep" did not work...
>
> Did you add `#include "version.h"' to dvbcut.cpp?

Of course, I did. And the first build process was ok, but after "touch"ing
some header file version.h was not re-build...

ciao
Ralph

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
DVBCUT-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dvbcut-user

Reply via email to