Hi!

On 04/24/11 02:46, David Timms wrote:

> I attach a patch that modifies progresswindow.cpp to perform the above.

Thanks, I'll look at it.

> Some queries:
> 1. To me, it would make sense to change "cancelbutton" to
> "cancelorclosebutton" to inform of it's new purpose. This seems to
> require changing the .ui as well as code in progresswindow.cpp/h
> 
> Shall I do that ?

Don't bother. The code is a mess anyway.

> 2. If escape is pressed during export, the progress form disappears.
> However, export continues, and at the end, the progresswindow reappears,
> with the correct green-close button, and the button works.
> [I think this may have always been present].

I think so, too.

> 3. When changing the button's text/colour, I disable, change, re-enable.
> Is this necessary / useful ?

Just changing the color should suffice, but I like it this way.

> 4. Is this a translated app ? Do I just use "Close", or does this need
> to access some i10n code / translation tables ?

I'll put a `tr()' around it - that's what Qt uses internally, too.

-- 
Michael "Tired" Riepe <mich...@mr511.de>
X-Tired: Each morning I get up I die a little

------------------------------------------------------------------------------
Fulfilling the Lean Software Promise
Lean software platforms are now widely adopted and the benefits have been 
demonstrated beyond question. Learn why your peers are replacing JEE 
containers with lightweight application servers - and what you can gain 
from the move. http://p.sf.net/sfu/vmware-sfemails
_______________________________________________
DVBCUT-user mailing list
DVBCUT-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dvbcut-user

Reply via email to